Retire ZpDlog from crypto/dlogs

xlab-si / emmy

Library for zero-knowledge proof based applications (like anonymous credentials)

Apache License 2.0

233 stars 54 forks source link

Retire ZpDlog from crypto/dlogs #38

Closed mancabizjak closed 6 years ago

mancabizjak commented 6 years ago

This PR includes refactoring that retires struct ZpDlog.

The file zp.go from crypto/dlog package is removed, all its references are updated to make use of struct SchnorrGroup from crypto/groups package. Some variables and function names are renamed for clarity.

mancabizjak commented 6 years ago

@miha-stopar There, I implemented a TODO that was in the new crypto/groups/schnorr.go, which was supposed to replace crypto/dlog/zp.go. Please let me know if you prefer to rename specific function names (that still have "DLog" in their names) too.

miha-stopar commented 6 years ago

No, no need for renaming. Structs such as DLogEqualityBTranscriptVerifier and DLogEqualityProver should have DLog in its name, because they are about dlogs (as I said in a comment, group is only a place where dlog is computed).