search

xlab-si / emmy

Library for zero-knowledge proof based applications (like anonymous credentials)
Apache License 2.0
233 stars 54 forks source link

Consider mage.go to replace Makefile #87

Closed ghost closed 6 years ago

ghost commented 6 years ago

It makes it easy to run make on all desktops and you CI. That's because it's just golang. You can run it compiled of interpreted ( like make files). It just needs a golang install.

I got it working with vgo to replace deposit also.

Solved a ton of little issues and now runs everywhere consistently everywhere.

https://github.com/magefile/mage

https://godoc.org/golang.org/x/vgo

See tour of vgo to get started.

I plan to put up an example repo but it's not yet separated from lots of other crap.

ghost commented 6 years ago

https://github.com/golang/vgo

janhartman commented 6 years ago

I don't see a good reason to switch to Mage as our Makefile isn't too complicated. I agree that using it removes the inconvenience of needing to have make installed (which is mostly a problem on Windows), but it does add another dependency.

As the docs state, vgo is still a very early prototype. Dep, on the other hand, is more mature and safe for production use. For now, I would avoid vgo because of the potential issues - maybe we could make the switch when it becomes stable and potentially replaces dep.

ghost commented 6 years ago

how to run a Makefile on Windows ? You can but its painful.

VGO is new. SO far i have hit no issues and when i do they fix them in 1 day.

G

On Wed, 18 Apr 2018 at 11:12 Jan Hartman notifications@github.com wrote:

I don't see a good reason to switch to Mage as our Makefile isn't too complicated. I agree that using it removes the inconvenience of needing to have make installed (which is mostly a problem on Windows), but it does add another dependency.

As the docs state, vgo is still a very early prototype. Dep, on the other hand, is more mature and safe for production use. For now, I would avoid vgo because of the potential issues - maybe we could make the switch when it becomes stable and potentially replaces dep.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xlab-si/emmy/issues/87#issuecomment-382319990, or mute the thread https://github.com/notifications/unsubscribe-auth/ATuCwmZqiD1qBXNiIf6ZqT8xB1kJd2iNks5tpwN3gaJpZM4TZpR4 .

ghost commented 6 years ago

this is a helepr file for mage if you decide later to use it. I use this. there are a ton of others as golang pkgs and so it makes all your build workfows as easy a go import.

https://github.com/zvelo/zmage

On Wed, 18 Apr 2018 at 11:33 Ged Wed gedw99@gmail.com wrote:

how to run a Makefile on Windows ? You can but its painful.

VGO is new. SO far i have hit no issues and when i do they fix them in 1 day.

G

On Wed, 18 Apr 2018 at 11:12 Jan Hartman notifications@github.com wrote:

I don't see a good reason to switch to Mage as our Makefile isn't too complicated. I agree that using it removes the inconvenience of needing to have make installed (which is mostly a problem on Windows), but it does add another dependency.

As the docs state, vgo is still a very early prototype. Dep, on the other hand, is more mature and safe for production use. For now, I would avoid vgo because of the potential issues - maybe we could make the switch when it becomes stable and potentially replaces dep.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xlab-si/emmy/issues/87#issuecomment-382319990, or mute the thread https://github.com/notifications/unsubscribe-auth/ATuCwmZqiD1qBXNiIf6ZqT8xB1kJd2iNks5tpwN3gaJpZM4TZpR4 .

janhartman commented 6 years ago

WSL is a great way to run tools like make on Windows. Thank you for the helper file - it will be helpful if we decide to use mage. I'd rather see we encounter as few issues as possible with a dependency management tool - for now, dep is probably the best choice for this project.

ghost commented 6 years ago

Does not help because you dont have proper access to the windows system. Been there and done that.

anyway...

On Wed, 18 Apr 2018 at 11:40 Jan Hartman notifications@github.com wrote:

Closed #87 https://github.com/xlab-si/emmy/issues/87.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/xlab-si/emmy/issues/87#event-1581014837, or mute the thread https://github.com/notifications/unsubscribe-auth/ATuCwjOdPVdqiopPlnsH2LRtxZtyXBD3ks5tpwoegaJpZM4TZpR4 .