Retire crypto/zkp/commitments, crypto/commitments

xlab-si / emmy

Library for zero-knowledge proof based applications (like anonymous credentials)

Apache License 2.0

233 stars 54 forks source link

Retire crypto/zkp/commitments, crypto/commitments #99

Closed mancabizjak closed 6 years ago

mancabizjak commented 6 years ago

Continues refactoring series (#97, #98).

This PR retires crypto/zkp/commitments and crypto/commitments packages. Commitments were placed into new packages df, qoneway, pedersen and ecpedersen packages.

I also updated the README and docs/theory document.

mancabizjak commented 6 years ago

Thanks for the feedback! Makes perfect sense, I added the preimage package with Prover, Verifier, and PartialProver, PartialVerifier structs.

mancabizjak commented 6 years ago

I just noticed we don't mention preimage proofs anywhere in the README. Should I add an entry under the Zero-knowledge proofs section?

miha-stopar commented 6 years ago

Yes, please mention it in README. There is some information about preimage in theory.md but not much actually - I should extend it at some point.