xlab-si / xopera-examples

Runnable TOSCA examples for xOpera orchestrator
https://xlab-si.github.io/xopera-docs/07-examples.html
Creative Commons Attribution 4.0 International
5 stars 2 forks source link

missed imports #28

Closed philippemerle closed 3 years ago

philippemerle commented 3 years ago

We should assume that a TOSCA type used in a service template file shall be 1) defined in this file, or 2) defined in one of imported files, or 3) a TOSCA normative type. Several xOpera examples files use types undefined, i.e., import definitions are missed.

For instance, cloud/aws/thumbnail-generator-with-api-gateway/modules/lambda/lambda.yaml uses the type radon.nodes.aws.api_gateway but this type is not defined locally and there is no import definition. Adding an import definition to lambda.yaml, i.e.

imports:
  - ../bucket_notification/bucket_notification.yaml

resolves this issue.

philippemerle commented 3 years ago

Files where an undefined type is used, i.e. an import definition is missed, are:

philippemerle commented 3 years ago

See PR https://github.com/xlab-si/xopera-examples/pull/29

anzoman commented 3 years ago

@philippemerle thanks a lot for spotting and correctinge these issues!