search

xlab-si / xopera-opera

xOpera orchestrator compliant with TOSCA YAML v1.3 in the making
https://xlab-si.github.io/xopera-docs/
Apache License 2.0
35 stars 14 forks source link

Add validation for executors (from TOSCA interface operations) #210

Closed anzoman closed 2 years ago

anzoman commented 3 years ago

With these changes we make it possible to validate xOpera's executors such as Ansible playbooks with opera validate. Till now the CLI command has been offering only the validation of TOSCA templates which was good but it failed to catch some important errors that might happen during the deployment (like #193). This new feature now offers the pre-check for the deployment and undeployment of TOSCA nodes and relationships since it creates initial instances. We used Ansible syntax check mode to execute Ansible playbooks in a "dry run" mode.

Must be merged after #209.

anzoman commented 3 years ago

@sstanovnik thanks for the review, all comments are now resolved.

sstanovnik commented 2 years ago

Looks good! Rebase and this is finally over! :sweat_smile:

anzoman commented 2 years ago

@sstanovnik thanks, the PR is rebased and ready to merge (after the checks pass).

anzoman commented 2 years ago

@sstanovnik ah the CI is failing again because of the integration tests that use kill command to test the CLI command interruption. This is now happening to often and I'm removing these parts of tests in a new separate commit. Please take a look and merge if everything seems fine.