xlab-si / xopera-opera

xOpera orchestrator compliant with TOSCA YAML v1.3 in the making
https://xlab-si.github.io/xopera-docs/
Apache License 2.0
35 stars 14 forks source link

xOpera does not detect missing requirements #211

Closed mikidep closed 2 years ago

mikidep commented 3 years ago

Steps to replicate

Expected behaviour

xOpera should complain about the missing requirement.

Current behaviour

xOpera validates the template without errors.

Possible cause of the issue

In file src/opera/template/node.py, in method resolve_requirements, only requirements that appear in the node template are checked; requirements specified in the node type that do not appear in the node template are not. In fact, it seems that node type information in general is not carried over to the parsed topology, but only the type name is.

anzoman commented 3 years ago

Hi, many thanks for bringing this up, we'll try to resolve this issues as soon as possible.

anzoman commented 2 years ago

This has been fixed in cf52b433b612002ac56da96033c0c41dfb2a8ad3 and considering the example above opera would now output Missing requirements: host.