search

xlab-uiuc / IDoCT

Illinois Dataset of Configuration Tests
3 stars 23 forks source link

Add new Ctests to Metadata #1

Closed moogician closed 2 years ago

moogician commented 2 years ago

I used the run_ctests/run_single_ctest.py to check whether a test in hadoop-common is a Ctest or not. I found the following Ctests, the detailed information for which have been added to the ctest_metadata.csv:

For each test above, I listed the part of the parameters which has at least one misconfiguration that the Ctest identified could detect. For other parameters, I only included the good configurations and didn't find bad configurations these tests could fail on. I've included all the entries in ctest_metadata.csv, in which the VALUEs wrapped by double quotation marks is used to avoid being misparsed by csv and are equivalent to that without the quotation marks.

shuaiwang516 commented 2 years ago

Thank you @hwang-pku for this PR!

This looks good to me. One thing I noticed is that most bad values here are bad-type values (e.g. required an integer but get a string). This is definitely one right way to do it. Besides this, you can also try some other bad values, for example, use a negative number for thread-number, a correct value with an incorrect unit (e.g. 30x for hadoop.service.shutdown.timeout since x is an undefined unit).

xylian86 commented 2 years ago

@hwang-pku Pretty good and reasonable PR! Thanks! Hope you can feel the charm of Ctest now. :)

tianyin commented 2 years ago

@hwang-pku Thanks for the PR! It's very cool!

And, it's the first contribution to IDoCT and we are very grateful to the work!