search

xlab-uiuc / memtis

Tiered memory management
0 stars 0 forks source link

Underflow of `nr_exceeded` in `need_toptier_demotion()` #7

Closed yulistic closed 4 weeks ago

yulistic commented 1 month ago

A negative value is assigned to nr_exceeded of which type is unsigned long. It makes a demotion stuck within an infinite loop.

yulistic commented 1 month ago

The watermarks are defined with constants at https://github.com/xlab-uiuc/memtis/blob/cxl-run-bench/linux/mm/htmm_migrater.c#L22.

We may need to adjust the constants or just make nr_exceeded to zero if a negative value is assigned.

yulistic commented 4 weeks ago

Fixed. Related commit: 97199066b, 50560af4c