search

xlab-uiuc / slooo

Slooo: A Fail-slow Fault Injection Testing Framework
11 stars 1 forks source link

bad name #22

Closed tianyin closed 2 years ago

tianyin commented 2 years ago

https://github.com/xlab-uiuc/slooo/blob/main/utils/general.xsh

general is a very bad name. It's hard for me to know what is general code.

It seems all the code there are related to VM ops? If that's the case, please rename it to vm_utils

varshith15 commented 2 years ago

its basically the common code the one that is reused by all the databases.

tianyin commented 2 years ago

You can't simply remove it @varshith15 !!

See https://github.com/xlab-uiuc/slooo/blob/main/SUT/rethink/temp.xsh#L10

varshith15 commented 2 years ago

smh. xonsh doesn't have a safe refactor option, hopefully, someone comes up with a xonsh ide extension soon. updated it.