xlang-ai / UnifiedSKG

[EMNLP 2022] Unifying and multi-tasking structured knowledge grounding with language models
https://arxiv.org/abs/2201.05966
Apache License 2.0
549 stars 58 forks source link

[Bug] When running without WandB, the `wandb_run_dir` is None #21

Closed ShaneTian closed 2 years ago

ShaneTian commented 2 years ago

When running without WandB, the self.wandb_run_dir is None. It will raise a FileNotFoundError.

https://github.com/HKUNLP/UnifiedSKG/blob/ecba08f7c81b2472c4046286e38e5f9ffe896d84/utils/trainer.py#L343-L353

https://github.com/HKUNLP/UnifiedSKG/blob/ecba08f7c81b2472c4046286e38e5f9ffe896d84/train.py#L133-L145

Timothyxxx commented 2 years ago

Indeed, we will fix that sooner.

Thanks for finding this bug!🥰

ChenWu98 commented 2 years ago

Hi, we fixed this bug in our latest commit. Thanks again for this information!