Update to newer sentence-transformers with offline usage and renaming of classes to match the released package

racinmat commented 7 months ago

This PR fixes several things and it's both #113 and my own additions and fixes.

PR #92 renamed few classes, introducing incompatibility with the previous released versions. This should not be happening between patch versions, thus this PR reverts it.
increasing patch version in setup.py
now, the instructor can be used in completely offline settings with model stored locally, without touching internet, with newer sentence-transformers
increased minimal version of sentence-transformers to reflect the change
uses device instead of _target_device, this does not change the behavior, but get rids of annoying deprecation warning.

@hongjin-su please, review and merge this PR if you find it ok, thanks.

mijalapenos commented 6 months ago

Thank you for the PR, seems to work with the latest sentence-transformers for me! I hope it gets merged soon.

racinmat commented 6 months ago

Glad to hear it from fellow CTU student. I hope it will get merged too, we are currently using my fork in production and it works well. Tagging other maintainers: @taoyds @Harry-hash

racinmat commented 4 days ago

@hongjin-su could you please release a new version to pypi? thanks

xlang-ai / instructor-embedding

Update to newer sentence-transformers with offline usage and renaming of classes to match the released package #115