search

xlar54 / ultimateii-dos-lib

cc65 library for accessing the DOS and network functions of the Ultimate II+ cartridge and Ultimate 64 motherboard
GNU General Public License v3.0
60 stars 13 forks source link

bell fix #35

Closed xlar54 closed 5 years ago

xlar54 commented 5 years ago

Seems that the terminal bell stop sounding. I implemented the bell in the assembly code, which seems to work fine now. Please test and confirm

xlar54 commented 5 years ago

removed old term_bell function. Tests ok for me. Reply here if good for you and Ill merge

sblendorio commented 5 years ago

we can avoid code duplication at all calling term_bell from within asm

asm("jsr %v", term_bell)

On Tue, Mar 26, 2019 at 3:01 PM Scott Hutter notifications@github.com wrote:

@xlar54 commented on this pull request.

In src/ultimateterm.c https://github.com/xlar54/ultimateii-dos-lib/pull/35#discussion_r269116919 :

@@ -187,7 +186,9 @@ void term_displayheader(void) {

void putstring_ascii(char str) { for (; str; str++)

  • if (str != LF) str==BELL ? term_bell() : putchar(ascToPet[*str]);
  • if (*str != LF) {

yeah, youre right. Ive reverted the term_bell function for that purpose for now. As bad as duplicated code is, its very small. And, we can use the bell function for other things as well, such as connection notification or termination notification.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/xlar54/ultimateii-dos-lib/pull/35#discussion_r269116919, or mute the thread https://github.com/notifications/unsubscribe-auth/ACBUnQ4WjDzu6SBkq-Ir0Gy7Hwv6hpqsks5vaigvgaJpZM4cHHJ_ .

-- Francesco Sblendorio http://fsblendorio.blogspot.com http://www.sblendorio.eu

xlar54 commented 5 years ago

makes sense - will do that