xlash123 / KHUx-Discord-Bot

A Discord bot that will aid players in getting information about the mobile game Kingdom Hearts Union X.
12 stars 7 forks source link

[Request] !lux check and set command #9

Closed KyetoJ closed 6 years ago

KyetoJ commented 7 years ago

Hi, sorry to bother but I was wondering and hoping if you would be able to put in a lux check command as in when you type in "!lux check" it would say how long until the double lux time. Ive had a slightly confusing time on my end trying to get the reminders to work as they didnt run at the time I thought they should have (however i think it was because I had set the default type to JP) but I just feel like having a check command would also be useful. Also if it would be possible to set a lux time as well, as ive just had the alert come up about an hour ago however this isnt the time thats normally used for my party at least. I just think it would be awesome if we could set it to run at specific lux times. So something kinda like "!lux set time1" which would set it to the one that just happened. And then 2 and 3 would be the later ones. Anyway sorry for disturbing again, these are just the thoughts ive been having. Thanks in advance!

xlash123 commented 7 years ago

My bad on the times. I looked back and saw I had it completely wrong. I've fixed it in 1.2.5. As for the suggestions, I'll try to implement it in the next version.

NickEscla commented 7 years ago

I experienced an issue with the bot not reporting the second bonus hour (8 am), though it worked fine on the 2 am one.

daltowon commented 7 years ago

I can second what NickEscla said. For some reason, even with lux reminders enabled, the bot doesn't want to announce the bonus hours. He has done this with 11a.m. Eastern, as well as 5p.m. Eastern.

xlash123 commented 7 years ago

It was working fine in my development environment, but I also noticed it not reporting lux times. In fact, the log said it failed to enable it. I'll try to put out a fix tonight.

NickEscla commented 7 years ago

I got 1.2.6 and it just missed the 8pm bonus hour just now

daltowon commented 7 years ago

That's odd, because the bot sent out the notification just fine for me.

xlash123 commented 7 years ago

Was lux enabled @NickEscla ?

NickEscla commented 7 years ago

Yes, I double checked right before. I can send you some logs

On Jun 19, 2017 8:33 PM, "Noah" notifications@github.com wrote:

Was lux enabled @NickEscla https://github.com/nickescla ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xlash123/KHUx-Discord-Bot/issues/9#issuecomment-309635438, or mute the thread https://github.com/notifications/unsubscribe-auth/APUc9fhT_y0br8XqUDzFF1xWVG8y0luAks5sFz2fgaJpZM4N5kTE .

xlash123 commented 7 years ago

It worked for me and it worked for the other guy, so give it a day. If it doesn't work again, I'll look into it. Also confirm that NA is the one being turned on, although I bet you have already.

NickEscla commented 7 years ago

Turning lux reminders off and on again fixed the issue as far as I can tell

NickEscla commented 7 years ago

The bot never posted about the end of bonus hour, and then never posted about the 2 pm bonus hour... Not sure what's going on on my side. I think only the first notice goes through

shanible commented 7 years ago

I agree with the OP about having different options for specific lux times. I'd like to take it a little further and be able to have each time reminder have a set channel option with their own custom message. Like suggested, maybe call them time1, time2, etc with the times attached to each a specific bonus time. That way, we set which ones we want on, where they post and what message goes with that time.

xlash123 commented 7 years ago

I'm creating an issue for lux times not working. Please use that thead for that issue.

xlash123 commented 7 years ago

As for the suggestion, I agree. I'll get to working on it

xlash123 commented 6 years ago

Added the check feature in 1.5.0. I don't think the set feature is necessary, but if you feel it really should be implemented, let me know.

xlash123 commented 6 years ago

In 1.8.0, I added the ability to select at which times you want the alerts to go off, which is basically the set feature that was described here, although it works through a menu that appears when running !lux on. Just in case anyone is still following this thread, now you know!