search

xlcnd / isbnlib

python library to validate, clean, transform and get metadata of ISBN strings (for devs).
Other
229 stars 30 forks source link

Add a network pytest mark for tests that use the network #121

Closed mcepl closed 1 year ago

mcepl commented 1 year ago

Is your feature request related to a problem? Please describe. Sometimes it's useful to have the tests that use the network marked so they can be skipped easily when we know the network is not available.

This is useful for example on SUSE and openSUSE's build servers. When building our packages the network is disabled so we can assure reproducible builds (among other benefits). With this mark, it's easier to skip tests that can not succeed.

Describe the solution you'd like suggested patch

xlcnd commented 1 year ago

Hi thanks.

Yes, it's a very good idea!