search

xlenore / psx-covers

PSX/PS1 Covers Collection
924 stars 34 forks source link

refactor for platform compatibility #30

Closed DarhkVoyd closed 1 year ago

DarhkVoyd commented 1 year ago

Updates:

  1. Fix the paths as they used '\' instead of '/'.
  2. The original name was too long and complex to execute in terminal easily so renamed it to simply covers.py
DarhkVoyd commented 1 year ago

Also I was getting:

urllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)>

adding "ssl._create_default_https_context = ssl._create_unverified_context" solved the issue

DarhkVoyd commented 1 year ago

@Zorklis kindly review this pull request

Zorklis commented 1 year ago

@Zorklis kindly review this pull request

Not sure why I was called here, since I only submitted one or two covers for PS1/PSX and that was with xlenore's helpful hand. I do have the power to commit on ps2 project but I don't have the knowledge/expertise in this area, hope someone helps you out :)

DarhkVoyd commented 1 year ago

@Zorklis kindly review this pull request

Not sure why I was called here, since I only submitted one or two covers for PS1/PSX and that was with xlenore's helpful hand. I do have the power to commit on ps2 project but I don't have the knowledge/expertise in this area, hope someone helps you out :)

I apologise for the misunderstanding, I saw you as as active collaborator.

DarhkVoyd commented 1 year ago

@xlenore kindly review

xlenore commented 1 year ago

@xlenore kindly review

Sorry for my inactivity, I will be updating the code of the 2 projects soon