search

xlgjjff / libtorrent

Automatically exported from code.google.com/p/libtorrent
Other
0 stars 0 forks source link

Active limits don't activate immediately with 1.0.0 #744

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This has been observed by a qbt user.
That version uses 1.0.4+svn11046.

Here is the original bug report: 
https://qbforums.shiki.hu/index.php/topic,3503.msg0.html

He has provided 4 pictures that illustrate the problem perfectly. I am linking 
to them below.

Apart from that I also have observed the same problem with seeding torrents. I 
usually have set "max active uploading" to 0. So a bunch of complete torrents 
are queued for upload. If I set it to 1, several torrents are started 
instantly. And then even if one torrent starts connecting the rest take a long 
time to stop being active and return to the queued state.

Pictures:

1. http://www.imagebam.com/image/a7696e410064096
2. http://www.imagebam.com/image/5dad7c410064102
3. http://www.imagebam.com/image/42594b410064106
4. http://www.imagebam.com/image/6d3c2b410064112

Original issue reported on code.google.com by hammered...@gmail.com on 16 May 2015 at 8:27

GoogleCodeExporter commented 8 years ago 
thanks for the report. could you try this patch please?

http://pastebin.com/AMP9sXwh

Original comment by arvid.no...@gmail.com on 19 May 2015 at 6:07

GoogleCodeExporter commented 8 years ago 
Sadly the user reports the same problem persists: 
https://qbforums.shiki.hu/index.php?topic=3503.msg17501#msg17501

Original comment by hammered...@gmail.com on 19 May 2015 at 8:24

GoogleCodeExporter commented 8 years ago 
sorry. I missed the key change (I blame it was late at night).

I haven't had time to write a unit test for this, but I hope to do that in 
trunk.

http://pastebin.com/30ZVWKvT

Original comment by arvid.no...@gmail.com on 20 May 2015 at 1:30

GoogleCodeExporter commented 8 years ago 
This has been fixed in RC_1_0 and will be included in the next stable release.

Original comment by arvid.no...@gmail.com on 31 May 2015 at 6:56

GoogleCodeExporter commented 8 years ago 
Sorry for the delay. I didn't get the notification from the user. It still 
fails.
Link: https://qbforums.shiki.hu/index.php?topic=3503.msg17583#msg17583
Or have you made a new patch?

Original comment by hammered...@gmail.com on 31 May 2015 at 6:59

GoogleCodeExporter commented 8 years ago 
the patch I checked in was a little bit different (but not materially 
different). I did however manually verify that it was fixed, in both RC_1_0 and 
trunk, with client_test. Perhaps there's some detail that I'm not reproducing 
accurately.

can you reproduce it in qbt?

Original comment by arvid.no...@gmail.com on 31 May 2015 at 9:49

GoogleCodeExporter commented 8 years ago 
OK, the user confirmed that it is fixed now.

Original comment by hammered...@gmail.com on 5 Jun 2015 at 6:30