search

xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
575 stars 74 forks source link

[Refactor]: config #604

Open themanforfree opened 6 months ago

themanforfree commented 6 months ago

Now all of our configurations are in a single file, utils/src/config.rs，It also contains a lot of parse_xxx, xxx_format, default_xxx methods, It's messy and difficult to manage. We need to organize these configurations into modules, each containing the configuration itself, its parse method, and default values.

In addition, the configuration can only be created through the new method, which is very inflexible, we need to refactor them use builder pattern, and it should be easy to modify existing configurations

caicancai commented 6 months ago

i want to try it

caicancai commented 5 months ago

Due to my personal time constraints, I abandon this issue. I am very sorry.

aryan-errs commented 5 months ago

Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out!

themanforfree commented 5 months ago

Hey @themanforfree , since caicancai is not working on this issue, i would like to try it out!

This issue has been assigned to you, thank you for your contribution

qstommyshu commented 5 months ago

Hi, I would like to take a look at this issue. Refactoring seems like a good starting to get to understand the codebase.

Phoenix500526 commented 4 months ago

@qstommyshu ，Harsh1s has initiate a pull request to solve this issue，can you try another good-first-issue? Thanks 😄