xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
596 stars 74 forks source link

fix: fix timeout when append entries #650

Closed iGxnon closed 4 months ago

iGxnon commented 8 months ago

Signed-off-by: iGxnon igxnon@gmail.com

Please briefly answer these questions:

Fix the lock order

No

codecov[bot] commented 8 months ago

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (d99ad0c) 74.71% compared to head (03656d4) 74.73%.

Files Patch % Lines
crates/curp/src/server/raw_curp/mod.rs 73.33% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #650 +/- ## ========================================== + Coverage 74.71% 74.73% +0.01% ========================================== Files 167 167 Lines 24159 24167 +8 Branches 24159 24167 +8 ========================================== + Hits 18051 18060 +9 + Misses 4991 4987 -4 - Partials 1117 1120 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bsbds commented 7 months ago

Please add more details about why the lock order could cause a timeout.

mergify[bot] commented 5 months ago

@iGxnon Your PR is in conflict and cannot be merged.

Phoenix500526 commented 4 months ago

Close this PR since it doesn't provide enough information in the description. Additionally, there are no cases to demonstrate that this PR solves any problems.