Closed Phoenix500526 closed 4 months ago
Attention: Patch coverage is 91.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 75.60%. Comparing base (
e35b35a
) to head (2c9504c
). Report is 92 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
crates/curp/src/members.rs | 91.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Phoenix500526 Your PR is in conflict and cannot be merged.
@Phoenix500526 Convert your pr to draft since CI failed
@Phoenix500526 Convert your pr to draft since CI failed
@Phoenix500526 Your PR is in conflict and cannot be merged.
@Phoenix500526 Your PR is in conflict and cannot be merged.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
cluster_validation
test case to cover the whole member add process.self_peer_urls
to match themember.peer_urls
and add client URLsare there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)