xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
596 stars 74 forks source link

fix: add keep alive logic for xlinectl lock command #666

Closed Phoenix500526 closed 4 months ago

Phoenix500526 commented 7 months ago

Closes: #664

Please briefly answer these questions:

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 75.22%. Comparing base (e35b35a) to head (138250e). Report is 28 commits behind head on master.

Files Patch % Lines
crates/xlinectl/src/command/lock.rs 0.00% 14 Missing :warning:
...xline-test-utils/src/bin/validation_lock_client.rs 0.00% 9 Missing :warning:
crates/xlinectl/src/command/lease/keep_alive.rs 0.00% 6 Missing :warning:
crates/xline-client/src/clients/lock.rs 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #666 +/- ## ========================================== - Coverage 75.55% 75.22% -0.34% ========================================== Files 180 182 +2 Lines 26938 26990 +52 Branches 26938 26990 +52 ========================================== - Hits 20353 20302 -51 - Misses 5366 5428 +62 - Partials 1219 1260 +41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Phoenix500526 commented 4 months ago

Closed since it's duplicated with pr #820