fix: xline watcher will loss event

Phoenix500526 commented 4 months ago

Closes: #677

Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) Add a HashSet to track all notified revision.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.90%. Comparing base (a44f710) to head (79a4c9e). Report is 19 commits behind head on master.

Files	Patch %	Lines
crates/xline/src/storage/kvwatcher.rs	84.61%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #678 +/- ## ========================================== + Coverage 74.36% 74.90% +0.53% ========================================== Files 170 172 +2 Lines 24834 25375 +541 Branches 24834 25375 +541 ========================================== + Hits 18467 19006 +539 + Misses 5225 5175 -50 - Partials 1142 1194 +52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangyuanpeng commented 3 months ago

have build the image on this PR and tested with https://github.com/xline-kv/Xline/pull/403 (single kubernetes cluster and single xline ),always success. (CI failed with too big log of xline debug for upload artifact)

xline-kv / Xline

fix: xline watcher will loss event #678

Codecov Report