Closed bsbds closed 1 month ago
Rebased on #705
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed
@Mergifyio rebase
rebase
@bsbds Convert your pr to draft since CI failed
Attention: Patch coverage is 86.86131%
with 18 lines
in your changes are missing coverage. Please review.
Project coverage is 75.64%. Comparing base (
e35b35a
) to head (26fdc28
). Report is 97 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
crates/curp/src/server/storage/wal/remover.rs | 86.86% | 7 Missing and 11 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@bsbds Convert your pr to draft since CI failed
@bsbds Your PR is in conflict and cannot be merged.
Depends-on: #705
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Implement WAL segment remover, the segment remover is used to make sure a wal segment file is atomically removed.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)