Closed Phoenix500526 closed 3 months ago
Attention: Patch coverage is 0%
with 238 lines
in your changes are missing coverage. Please review.
Project coverage is 74.48%. Comparing base (
0709eea
) to head (dafdb54
). Report is 9 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please briefly answer these questions: Currently, some gRPC requests and responses consist of bytes and are not human-readable. I implemented the Display trait for these requests and responses so they can be output in a more developer-friendly format. The reason for implementing Display instead of Debug is that Prost automatically derives Debug for all requests and responses. This pr can reduce the log content size which mentioned in issue #516 .
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) Implement Display trait for some requests and responses
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc) no