xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
565 stars 71 forks source link

Refactor/better debug #683

Closed Phoenix500526 closed 3 months ago

Phoenix500526 commented 4 months ago

Please briefly answer these questions: Currently, some gRPC requests and responses consist of bytes and are not human-readable. I implemented the Display trait for these requests and responses so they can be output in a more developer-friendly format. The reason for implementing Display instead of Debug is that Prost automatically derives Debug for all requests and responses. This pr can reduce the log content size which mentioned in issue #516 .

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 238 lines in your changes are missing coverage. Please review.

Project coverage is 74.48%. Comparing base (0709eea) to head (dafdb54). Report is 9 commits behind head on master.

Files Patch % Lines
crates/xlineapi/src/lib.rs 0.00% 214 Missing :warning:
crates/xline/src/server/auth_server.rs 0.00% 9 Missing :warning:
crates/xline/src/storage/kvwatcher.rs 0.00% 8 Missing :warning:
crates/xline/src/server/kv_server.rs 0.00% 4 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================== - Coverage 74.74% 74.48% -0.27% ========================================== Files 172 173 +1 Lines 25374 25871 +497 Branches 25374 25871 +497 ========================================== + Hits 18966 19270 +304 - Misses 5219 5399 +180 - Partials 1189 1202 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.