Closed ChaudharyRaman closed 3 months ago
@iGxnon @Phoenix500526 please review.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.34%. Comparing base (
75e51f4
) to head (0e95c8b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for your contribution. Could you please rebase this PR? The first two commits appear to be unrelated to issue #691. Additionally, the last commit message doesn't meet the requirements; please adjust it accordingly.FYI: https://github.com/xline-kv/Xline/blob/master/CONTRIBUTING.md#commits
This PR resolved this issue https://github.com/xline-kv/Xline/issues/691
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) During the startup process of Xline, certain essential command-line parameters such as
--member
and--storage-engine
are checked. and there is a lack of validation for--client-listen-urls
and--peer-listen-urls
what changes does this pull request make? Added validation for
![fix--help](https://github.com/xline-kv/Xline/assets/97114586/87a75ae3-67bd-492c-b9e9-fd671f3dd1c7)
--client-listen-urls
and--peer-listen-urls
Here's how it looks -are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)