xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
565 stars 71 forks source link

[Improvement] Added validation for --client-listen-urls and --peer-listen-urls #695

Closed ChaudharyRaman closed 3 months ago

ChaudharyRaman commented 3 months ago

This PR resolved this issue https://github.com/xline-kv/Xline/issues/691

Please briefly answer these questions:

ChaudharyRaman commented 3 months ago

@iGxnon @Phoenix500526 please review.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.34%. Comparing base (75e51f4) to head (0e95c8b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #695 +/- ## ========================================== - Coverage 74.38% 74.34% -0.04% ========================================== Files 173 173 Lines 25872 25872 Branches 25872 25872 ========================================== - Hits 19244 19235 -9 - Misses 5425 5438 +13 + Partials 1203 1199 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Phoenix500526 commented 3 months ago

Thank you for your contribution. Could you please rebase this PR? The first two commits appear to be unrelated to issue #691. Additionally, the last commit message doesn't meet the requirements; please adjust it accordingly.FYI: https://github.com/xline-kv/Xline/blob/master/CONTRIBUTING.md#commits