xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
565 stars 71 forks source link

feat: Added validation for --client-listen-urls and --peer-listen-urls #698

Closed ChaudharyRaman closed 3 months ago

ChaudharyRaman commented 3 months ago

This PR resolved this issue: https://github.com/xline-kv/Xline/issues/691 Please briefly answer these questions:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.39%. Comparing base (75e51f4) to head (cb0fbb0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #698 +/- ## ========================================== + Coverage 74.38% 74.39% +0.01% ========================================== Files 173 173 Lines 25872 25872 Branches 25872 25872 ========================================== + Hits 19244 19248 +4 + Misses 5425 5416 -9 - Partials 1203 1208 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChaudharyRaman commented 3 months ago

@Phoenix500526 @iGxnon Please review this PR. I closed the previous one and remove unnecessary commits and also just wanted to push from proper PR branch name from my local. Please tell me if there is anytime more to be done for this PR.

ChaudharyRaman commented 3 months ago

@Phoenix500526 is their any order in which a particular arguments needed to be shown, like right now --client-listen-urlsand --peer-listen-urls are first and then rest of the flags, i will change if required. While playing with Xline, i found a small ip-address issue with the quick_start.sh script for prometheus and quick-start DOC. Should i raise a issue for this or are we going to change the quick_start soon in this issue https://github.com/xline-kv/Xline/issues/692.

Phoenix500526 commented 3 months ago

@Phoenix500526 is their any order in which a particular arguments needed to be shown, like right now --client-listen-urlsand --peer-listen-urls are first and then rest of the flags, i will change if required. While playing with Xline, i found a small ip-address issue with the quick_start.sh script for prometheus and quick-start DOC. Should i raise a issue for this or are we going to change the quick_start soon in this issue #692.

Is the issue you mentioned above described in issue #692? If not, I think it's better to initiate a new issue to describe it.

ChaudharyRaman commented 3 months ago

Thanks @Phoenix500526 .Got it! I will raise a issue for this although its just a minor fix.