search

xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
565 stars 71 forks source link

[Feature]: Create a reusable gh workflow for build xline image #700

Closed liangyuanpeng closed 3 months ago

liangyuanpeng commented 3 months ago

Description about the feature

Currently, there are multiple workflows that require building xline container images. It is worth creating a reusable workflow for building container images.

Ideally, this reusable workflow will build the xline container image and upload the created image artifact through actions/upload-artifact.

Another option is to put the logic into a script and the user just needs to run a command like make build-container to build the container image.

The other things is the xline container image tag created in the current workflow is latest. I don't think this is a good idea. This is a real tag and in some scenarios it may be possible to pull the image from the repository instead of using the local.

Code of Conduct

ChaudharyRaman commented 3 months ago

Hi @liangyuanpeng @Phoenix500526 Please assign it to me. I would like to work on workflows. Thank You.

Phoenix500526 commented 3 months ago

Thanks for your contribution. @ChaudharyRaman

liangyuanpeng commented 3 months ago

@ChaudharyRaman Free feel to ask if you have any question here.

ChaudharyRaman commented 3 months ago

@liangyuanpeng sorry I was occupied with the college exam and writing a proposal for gsoc, will be raising a PR today for the issue.

liangyuanpeng commented 3 months ago

No worries, just according to your time to choice it.