Closed bsbds closed 1 month ago
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed
@bsbds Convert your pr to draft since CI failed
@Mergifyio rebase
rebase
@bsbds Convert your pr to draft since CI failed
@Mergifyio rebase --autosquash
rebase --autosquash
@Mergifyio rebase
rebase
Attention: Patch coverage is 77.67857%
with 25 lines
in your changes are missing coverage. Please review.
Project coverage is 75.62%. Comparing base (
e35b35a
) to head (4eed780
). Report is 61 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
crates/curp/src/server/storage/wal/segment.rs | 68.25% | 7 Missing and 13 partials :warning: |
crates/curp/src/server/storage/wal/codec.rs | 88.09% | 3 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Switch the curp WAL to synchronous implementation, as the current async version is slow in benchmarks.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)