feat: reuseable workflow

xline-kv / Xline

A geo-distributed KV store for metadata management

https://xline.cloud

Apache License 2.0

562 stars 71 forks source link

feat: reuseable workflow #738

Closed ChaudharyRaman closed 3 months ago

ChaudharyRaman commented 3 months ago

Fixes https://github.com/xline-kv/Xline/issues/700 Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?) Added reuseable workflow and implement in benchmark.yml and validation.yml
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.19%. Comparing base (85e7891) to head (58f001b). Report is 6 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #738 +/- ## ========================================== - Coverage 75.19% 75.19% -0.01% ========================================== Files 175 175 Lines 26803 26803 Branches 26803 26803 ========================================== - Hits 20155 20154 -1 - Misses 5438 5440 +2 + Partials 1210 1209 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChaudharyRaman commented 3 months ago

@Phoenix500526 @liangyuanpeng Please review and suggest for any changes and addition/fix in the script.

ChaudharyRaman commented 3 months ago

@Phoenix500526 Just pushed, Please check

liangyuanpeng commented 3 months ago

This PR resolved this issue - https://github.com/xline-kv/Xline/issues/700

Update to Fixes #700, and then it will auto close the issue when this PR is merged.

liangyuanpeng commented 3 months ago

requested a review from liangyuanpeng

LGTM and thanks, (I don`t have owners here.)

ChaudharyRaman commented 3 months ago

LGTM! Thanks for your work :)

Got it. Thanks! @bsbds Please Review.

liangyuanpeng commented 3 months ago

@ChaudharyRaman I think we still update here, do you want to continue it?

https://github.com/xline-kv/Xline/blob/eadf2d9a1473fa33e2c5017a5f6f1682742fa243/.github/workflows/pull_request.yml#L128-L151

ChaudharyRaman commented 3 months ago

@liangyuanpeng Yeah right, I would do that. Currently, I am working on GSOC proposal with dead-line so close, Will create a PR by tomorrow. Thank You.

ChaudharyRaman commented 3 months ago

@liangyuanpeng, Previously while implementing what i thought is the for actions/upload-artifact@v4 , we are using for upload Log and Benchmark, and since Upload logs depends on failure() || cancelled(). Its better to let it be there and so instead of creating new Upload, lets create a general Case for rest including Benchmark and _output/xline.tar. What do you say.