Closed Phoenix500526 closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.63%. Comparing base (
e35b35a
) to head (be2b6d8
). Report is 9 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Phoenix500526 this is LGTM and the reason of close it is this test is not required?
@Phoenix500526 this is LGTM and the reason of close it is this test is not required?
It's necessary, but we may not do it this way. Currently, the mergify bot requires explicit status checks; otherwise, it will ignore those that have failed but not checked statuses, potentially merging the pr into the master branch. Therefore a better way is to check all statues unless explicitly skipped in the .mergify.yml file.
Please briefly answer these questions: update modify bot to track e2e-kube status
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)