xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 71 forks source link

ci: update .mergeify bot #771

Closed Phoenix500526 closed 2 months ago

Phoenix500526 commented 2 months ago

Please briefly answer these questions: update modify bot to track e2e-kube status

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.63%. Comparing base (e35b35a) to head (be2b6d8). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #771 +/- ## ========================================== + Coverage 75.55% 75.63% +0.08% ========================================== Files 180 182 +2 Lines 26938 27015 +77 Branches 26938 27015 +77 ========================================== + Hits 20353 20433 +80 + Misses 5366 5363 -3 Partials 1219 1219 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liangyuanpeng commented 2 months ago

@Phoenix500526 this is LGTM and the reason of close it is this test is not required?

Phoenix500526 commented 2 months ago

@Phoenix500526 this is LGTM and the reason of close it is this test is not required?

It's necessary, but we may not do it this way. Currently, the mergify bot requires explicit status checks; otherwise, it will ignore those that have failed but not checked statuses, potentially merging the pr into the master branch. Therefore a better way is to check all statues unless explicitly skipped in the .mergify.yml file.