xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 71 forks source link

refactor: remove sleep_secs method when waiting the cluster to shutdown #786

Closed Phoenix500526 closed 1 month ago

Phoenix500526 commented 2 months ago

Please briefly answer these questions: Using a notify logic to instead the sleep logic in some integration test cases

mergify[bot] commented 2 months ago

@Phoenix500526 Convert your pr to draft since CI failed

mergify[bot] commented 2 months ago

@Phoenix500526 You've modified the workflows. Please don't forget to update the .mergify.yml.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.49%. Comparing base (e35b35a) to head (c377994). Report is 83 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #786 +/- ## ========================================== - Coverage 75.55% 75.49% -0.06% ========================================== Files 180 186 +6 Lines 26938 27472 +534 Branches 26938 27472 +534 ========================================== + Hits 20353 20741 +388 - Misses 5366 5460 +94 - Partials 1219 1271 +52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mergify[bot] commented 2 months ago

@Phoenix500526 Your PR is in conflict and cannot be merged.