Closed Phoenix500526 closed 2 weeks ago
👋 Thanks for opening this issue!
Reply with the following command on its own line to get help or engage:
/contributing-agreement
: to print Contributing Agreements./assignme
: to assign this issue to you.
After the pr #704 being merged, we got a
LogEntryVecDeque
implementation like this:As you can see,
batch_index
stores an offset. With this offset, we can calculate a log batch of size less than or equal tobatch_size
for any given indexi
(FYI: issue #368 ). We record the offset instead of the right bound in that the log may be compressed. However, there is a method namedli_to_pi
inLog
, which can transform the logical index to the physical index (The compression only changes the physical index ):Therefore, we think we can do some refactoring stuff: move
li_to_pi
and relevant fields, likebase_index
andbase_term
intoLogEntryVecDeque
.