xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 71 forks source link

Push the latest image on push master. #802

Closed liangyuanpeng closed 1 month ago

liangyuanpeng commented 2 months ago

Please briefly answer these questions:

Push the latest image for let people can be experience the master branch function in advance.

mergify[bot] commented 2 months ago

@liangyuanpeng You've modified the workflows. Please don't forget to update the .mergify.yml.

mergify[bot] commented 2 months ago

@liangyuanpeng Convert your pr to draft since CI failed

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.59%. Comparing base (e35b35a) to head (5025f79). Report is 49 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #802 +/- ## ========================================== + Coverage 75.55% 75.59% +0.04% ========================================== Files 180 187 +7 Lines 26938 27563 +625 Branches 26938 27563 +625 ========================================== + Hits 20353 20837 +484 - Misses 5366 5448 +82 - Partials 1219 1278 +59 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Phoenix500526 commented 1 month ago

IMO, it's better to provide a script to build the latest image from the master branch rather than to build an image from the master branch and push it into our image repo. It will upload many images that are unstable to our image repo. It may not be a good practice.

Phoenix500526 commented 1 month ago

@liangyuanpeng BTW, I am confused with these three workflows: merge_image.yml, release.yml, and docker_image.yml. The docker_image.yml workflow has not been triggered since it was created. Do you have any interest in refactoring them?

liangyuanpeng commented 1 month ago

It will upload many images that are unstable to our image repo.

It only "one" image---latest, the user should know that this is "The latest" image and not a stable image.

I would say this is a universal need. --> "I just want to use it and don't want to build it."

The docker_image.yml workflow has not been triggered since it was created.

I used this workflow to created the image for PR fix: xline watcher will loss event on my fork repo, see https://github.com/liangyuanpeng/Xline/actions/runs/8244904769

Do you have any interest in refactoring them?

please create a issue for it and i will pick it up when i have a time, or welcome everyone contribute.