xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 71 forks source link

chore: downgrade github artifact to v3 from v4 for publish docker image. #809

Closed liangyuanpeng closed 1 month ago

liangyuanpeng commented 1 month ago

Please briefly answer these questions:

artifact v4 do not support upload artifact with the same name, https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact , so this PR is working for downgrade v4 to v3, until we get rid of using github jobs to build multi-architecture container images.

so release workflow is also broken, https://github.com/xline-kv/Xline/blob/dca44495673ab0cf4c67ecb59110bbddcde22c74/.github/workflows/release.yml#L144

mergify[bot] commented 1 month ago

@liangyuanpeng You've modified the workflows. Please don't forget to update the .mergify.yml.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.47%. Comparing base (e35b35a) to head (769125e). Report is 92 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #809 +/- ## ========================================== - Coverage 75.55% 75.47% -0.08% ========================================== Files 180 186 +6 Lines 26938 27478 +540 Branches 26938 27478 +540 ========================================== + Hits 20353 20740 +387 - Misses 5366 5467 +101 - Partials 1219 1271 +52 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Phoenix500526 commented 1 month ago

Please ignore the auto update of the upload-artifact in dependabot.yml. Otherwise, it will be auto update in next time.

liangyuanpeng commented 1 month ago

Please add the explaination in the PR description into commit message.

Sure, PTAL again,Thanks.

liangyuanpeng commented 1 month ago

Since this PR have two approval, does ready merge it is time?