Closed liangyuanpeng closed 1 month ago
@liangyuanpeng You've modified the workflows. Please don't forget to update the .mergify.yml.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.47%. Comparing base (
e35b35a
) to head (769125e
). Report is 92 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please ignore the auto update of the upload-artifact in dependabot.yml. Otherwise, it will be auto update in next time.
Please add the explaination in the PR description into commit message.
Sure, PTAL again,Thanks.
Since this PR have two approval, does ready merge it is time?
Please briefly answer these questions:
artifact v4 do not support upload artifact with the same name, https://github.com/actions/upload-artifact?tab=readme-ov-file#not-uploading-to-the-same-artifact , so this PR is working for downgrade v4 to v3, until we get rid of using github jobs to build multi-architecture container images.
so release workflow is also broken, https://github.com/xline-kv/Xline/blob/dca44495673ab0cf4c67ecb59110bbddcde22c74/.github/workflows/release.yml#L144
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)