xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 70 forks source link

[Refactor] refactor Xline ci process #822

Open Phoenix500526 opened 1 month ago

Phoenix500526 commented 1 month ago

The following code snippet is taken from our pull_request.yml

...
jobs:
  test:
      ...
      strategy:
        fail-fast: true
        matrix:
          config:
            - {
                name: "Normal",
                args: "",
                rustflags: "",
                test: "llvm-cov nextest --all-features --workspace --codecov --output-path codecov.info",
              }
            - {
                name: "Madsim",
                args: "--package=simulation",
                rustflags: "--cfg madsim",
                test: "nextest run --package=simulation",
              }
      name: Tests ${{ matrix.config.name }}
      steps:
         ...
         - name: Clippy ${{ matrix.config.name }}
            env:
              RUSTFLAGS: ${{ matrix.config.rustflags }}
            run: cargo clippy ${{ matrix.config.args }} --all-targets --all-features -- -D warnings
        ....
        - name: Test ${{ matrix.config.name }}
           env:
              RUSTFLAGS: ${{ matrix.config.rustflags }}
            run: cargo ${{ matrix.config.test }}
       ....

As you can see, the usage of matrix.config.args in "Clippy ${{ matrix.config.name }}" and "Test ${{ matrix.config.name }}" is different. We can do some refactor staff to make them uniform.

github-actions[bot] commented 1 month ago

👋 Thanks for opening this issue!

Reply with the following command on its own line to get help or engage:

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 14 days.

bhavik-goplani commented 1 week ago

/assignme