xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 70 forks source link

feat: move id barrier to utils #851

Closed bsbds closed 1 week ago

bsbds commented 2 weeks ago

Make IdBarrier reusable

Please briefly answer these questions:

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.74%. Comparing base (e35b35a) to head (7d3222a). Report is 123 commits behind head on master.

Files Patch % Lines
crates/utils/src/barrier.rs 59.09% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #851 +/- ## ========================================== + Coverage 75.55% 75.74% +0.18% ========================================== Files 180 188 +8 Lines 26938 27830 +892 Branches 26938 27830 +892 ========================================== + Hits 20353 21079 +726 - Misses 5366 5457 +91 - Partials 1219 1294 +75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bsbds commented 1 week ago

There is another barrier named IndexBarrier in xline::server::barrier. Shall we move it into utils::barrier?

It will be removed in #857

CrystalAnalyst commented 1 week ago

LGTM