Closed bsbds closed 1 week ago
Attention: Patch coverage is 65.38462%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 75.74%. Comparing base (
e35b35a
) to head (7d3222a
). Report is 123 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
crates/utils/src/barrier.rs | 59.09% | 9 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There is another barrier named
IndexBarrier
inxline::server::barrier
. Shall we move it intoutils::barrier
?
It will be removed in #857
LGTM
Make
IdBarrier
reusablePlease briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)