Closed bsbds closed 1 week ago
@bsbds Convert your pr to draft since CI failed
Attention: Patch coverage is 96.36364%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 75.65%. Comparing base (
e35b35a
) to head (d99d45a
). Report is 123 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The keys are not necessary in serialization, we could generate keys only when being used.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)