xline-kv / Xline

A geo-distributed KV store for metadata management
https://xline.cloud
Apache License 2.0
562 stars 70 forks source link

refactor: remove keys from command #852

Closed bsbds closed 1 week ago

bsbds commented 2 weeks ago

The keys are not necessary in serialization, we could generate keys only when being used.

Please briefly answer these questions:

mergify[bot] commented 2 weeks ago

@bsbds Convert your pr to draft since CI failed

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 96.36364% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.65%. Comparing base (e35b35a) to head (d99d45a). Report is 123 commits behind head on master.

Files Patch % Lines
crates/xline/src/server/kv_server.rs 50.00% 2 Missing :warning:
crates/xline/src/server/lock_server.rs 0.00% 1 Missing :warning:
crates/xline/src/storage/compact/mod.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #852 +/- ## ========================================== + Coverage 75.55% 75.65% +0.09% ========================================== Files 180 187 +7 Lines 26938 27767 +829 Branches 26938 27767 +829 ========================================== + Hits 20353 21006 +653 - Misses 5366 5469 +103 - Partials 1219 1292 +73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.