search

xlmnxp / blue-recorder

Simple Screen Recorder written in Rust based on Green Recorder
Other
525 stars 26 forks source link

Do not overwrite by default #23

Closed joeitu closed 2 years ago

joeitu commented 2 years ago

Hello,

I had 90min important zoom meeting that I recorded with blue recorder.

At the end of the meeting, I go to the blue recorder window to stop the recording, when clicking nothing happens, the app has frozen. So I double-click again.

Blue recorder stop freezing and I now realize that my extra clicks have stopped the recorder and started a new one with the same file name. It has overwritten my 90min recording for a 2sec recording of me clicking nervously on the Stop button.

Software with data loss hazards should be strongly labeled as experimental, and should not be launched in the wild. I find it unacceptable that I found this software in PopOS software center.

For the sack of open-source reputation, please check if the file exists before writing to it and until then keep it away from software stores and package repositories.

me00001 commented 2 years ago

This feature is available in the beta branch

But since blue recorder version hasn't changed yet https://github.com/xlmnxp/blue-recorder/blob/bacc198bd0d40c970abfd36742c1e8b700e5369f/Cargo.toml#L2-L3 i kept any update to beta branch, and will merge it into master branch when the version is updated

joeitu commented 2 years ago

I think you should either update the master asap, or remove it from the flatpack repo to avoid any other data loss. When users download packages from flatpack they expect a certain software quality which includes overwriting prevention.

xlmnxp commented 2 years ago

@joeitu we will make a release today 0.1.5 for add this feature (which already requested from other users #22 and we add it), sorry for lose your video by overwrite it

xlmnxp commented 2 years ago

snap version released to stable channel

joeitu commented 2 years ago

Awesome, thank you @xlmnxp :+1:

xlmnxp commented 2 years ago

flathub released 👍🏼 can you test it @joeitu ?

xlmnxp commented 2 years ago

I think it fixed

xlmnxp commented 2 years ago

thank you @me00001 @joeitu

joeitu commented 2 years ago

Hmm Pop os shop tell me that the software is up to date, but the "about" button in blue recorder show me version 1.4 But I believe this issue rely on the pop shop side.

xlmnxp commented 2 years ago

Hmm Pop os shop tell me that the software is up to date, but the "about" button in blue recorder show me version 1.4 But I believe this issue rely on the pop shop side.

sorry for that, I didn't change the version number in about dialog but you can try record video and then try to overwrite it

joeitu commented 2 years ago

Yes it works ! :tada:

Thanks for being so quick fixing that issue :ok_hand:

xlmnxp commented 2 years ago

Yes it works ! tada

Thanks for being so quick fixing that issue ok_hand

Great 👍🏼