search

xlsdg / vue-countup-v2

Vue.js component wrap for countUp.js
https://inorganik.github.io/countUp.js/
MIT License
380 stars 56 forks source link

🚑 add a prop 'decimalPlaces' for more flexible use #29

Open qinhua opened 3 years ago

qinhua commented 3 years ago

@xlsdg Add a prop 'decimalPlaces' for more flexible use.

Just fixed the issue #28 'Decimal places property missing'.

Decimal places property missing #28 What happened to the decimals property? In a much earlier version there was a property that allowed for setting the decimal places. Now it's being ignored and I see no reference to it in the docs.

Cause I encountered this scene, too. But the original property must place in the config, a little bit inflexible when configurate more than one instance.

The modifications are as follows: decimalPlaces: { type: Number, required: ##false, default: 0, }

const config = that.decimalPlaces ? Object.assign({}, that.options, { decimalPlaces: that.decimalPlaces, }) : that.options;

const instance = new CountUp( dom, that.endVal, config );

steveDL commented 3 years ago

Is this going to be merged in soon I need to use decimals?

qinhua commented 3 years ago

@xlsdg Please check this code