search

xlzior / pe

0 stars 0 forks source link

Module codes are a little too restrictive as there are modules with four-letter codes #2

Open xlzior opened 2 years ago

xlzior commented 2 years ago

Steps to reproduce

Add someone with a module code that starts with a four characters e.g. add n/John Doe e/john@gmail.com m/GESS1000

Expected

App should allow this

Actual

image.png

Justification

Overzealous input validation: "blocking that input might not add any value but allowing it does"

I believe there are new GESS modules that have four-character codes

image.png

nus-pe-bot commented 2 years ago

Team's Response

As we were creating the regex checks for module code, we checked the module website for restrictions to the NUS module codes.

We found that it should only be 2-3 characters long.

image.png

While we accept that the new module GESS exists, we are not aware of it as it is new and the official website does not reflect this.

Hence we believe this bug is not in scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]