xmake-io / xmake-repo

📦 An official xmake package repository
https://xrepo.xmake.io
Apache License 2.0
685 stars 396 forks source link

Got a wrong opensslconf.h(i386) when installed libressl-3.7.3(x64) #2900

Open UMU618 opened 11 months ago

UMU618 commented 11 months ago

Xmake Version

2.8.5

Operating System Version and Architecture

Windows 11 23H2

Describe Bug

Got a wrong opensslconf.h, when installed libressl-3.7.3, should be amd64 version, actually i386 version.

Expected Behavior

%LocalAppData%.xmake\packages\l\libressl\3.7.3\1efe7c3f8b8d4b659e11b98d540b0c92\include\openssl\opensslconf.h should be amd64 version. (The same as %LocalAppData%.xmake\packages\l\libressl\3.7.3\1efe7c3f8b8d4b659e11b98d540b0c92\include\arch\amd64\opensslconf.h)

Project Configuration

no project, I just install packages.

Additional Information and Error Logs

xrepo install -y libressl
checking for Microsoft Visual Studio (x64) version ... 2022
  => download https://github.com/xmake-mirror/build-artifacts/releases/download/libressl-3.7.3/windows-x64-vc142-1efe7c3f8b8d4b659e11b98d540b0c92.7z .. ok
  => install libressl 3.7.3 .. ok
waruqi commented 11 months ago

you can debug this package https://github.com/xmake-io/xmake-repo/blob/dev/packages/l/libressl/xmake.lua

or open an issue to upstream openssl.

UMU618 commented 11 months ago

or open an issue to upstream openssl.

It's not a bug of upstream openssl or libressl. They provide all arches, but xmake doesn't copy the right arch.

should copy %LocalAppData%\.xmake\packages\l\libressl\3.7.3\1efe7c3f8b8d4b659e11b98d540b0c92\include\arch\amd64\opensslconf.h to %LocalAppData%\.xmake\packages\l\libressl\3.7.3\1efe7c3f8b8d4b659e11b98d540b0c92\include\opensslconf.h

waruqi commented 11 months ago

or open an issue to upstream openssl.

It's not a bug of upstream openssl or libressl. They provide all arches, but xmake doesn't copy the right arch.

should copy %LocalAppData%\.xmake\packages\l\libressl\3.7.3\1efe7c3f8b8d4b659e11b98d540b0c92\include\arch\amd64\opensslconf.h to %LocalAppData%\.xmake\packages\l\libressl\3.7.3\1efe7c3f8b8d4b659e11b98d540b0c92\include\opensslconf.h

xmake will not copy them, it only call make install to install these files to install directory.

https://github.com/xmake-io/xmake-repo/blob/fe02c217749deab9c8d9c843f74cf82eeece75f4/packages/l/libressl/xmake.lua#L31

so libressl/make install doesn't copy the right arch.

UMU618 commented 11 months ago

vcpkg works well, but its libressl is v3.8.2.

Can you add v3.8.2?

waruqi commented 11 months ago

vcpkg works well, but its libressl is v3.8.2.

Can you add v3.8.2?

you can open a pr to xmake-repo