xmake-io / xmake-repo

📦 An official xmake package repository
https://xrepo.xmake.io
Apache License 2.0
627 stars 377 forks source link

mimalloc 2.1.7 & 1.8.7 #4612

Closed maximegmd closed 2 weeks ago

maximegmd commented 2 weeks ago

waruqi commented 2 weeks ago

Please add only one version per pr for ci test

SirLynix commented 2 weeks ago

since a newer version than 1.8.7 is already present, the CI won't test it anyway, it only tests the last one, right?

waruqi commented 2 weeks ago

since a newer version than 1.8.7 is already present, the CI won't test it anyway, it only tests the last one, right?

right, this would require an improved test script, or commenting out the higher version first to test the lower version.

star-hengxing commented 2 weeks ago

Improve test script or make two package

mimalloc1 -> 1.x mimalloc -> 2.x

SirLynix commented 2 weeks ago

I don't think we should split packages by their version except in some cases (like openssl) maybe we could somehow extract added version in the test script, based on git diff perhaps

star-hengxing commented 2 weeks ago
add_version_branch("1.x", "2.x")
-- Test script will test 1.x and 2.x latest version
SirLynix commented 2 weeks ago
{ 
  "mimalloc 2.1.7",
  "mimalloc 1.8.7",
}

amazing!