xmake-io / xmake-repo

📦 An official xmake package repository
https://xrepo.xmake.io
Apache License 2.0
685 stars 396 forks source link

centurion: add package #4953

Closed ilobilo closed 2 months ago

ilobilo commented 2 months ago

ilobilo commented 2 months ago

what can I do about failing checks?

star-hengxing commented 2 months ago

https://github.com/xmake-io/xmake-repo/blob/a1a5ca1ff583456ed9519703bdcdf00ce3fa2c0b/packages/l/libsdl/xmake.lua#L249-L255

ilobilo commented 2 months ago

oh oops, I copied the function from some package

Chi-EEE commented 2 months ago

maybe add:

if is_plat("wasm") then
    add_configs("shared", {description = "Build shared library.", default = false, type = "boolean", readonly = true})
end

since the other libsdl packages have it

ilobilo commented 2 months ago

maybe add:

if is_plat("wasm") then
    add_configs("shared", {description = "Build shared library.", default = false, type = "boolean", readonly = true})
end

since the other libsdl packages have it

done

ilobilo commented 2 months ago

what does it want now

star-hengxing commented 2 months ago

@c8ef https://github.com/xmake-io/xmake-repo/commit/e167e3a9cc6d83706c50908306f7227c1d47f119 break android ci :(

c8ef commented 2 months ago

It appears that the API has been officially deprecated in NDK 27. I believe cherry-picking https://github.com/libsdl-org/SDL/commit/558630d59c2db73ac7c0c0cae000e4bee6ef42cf should be sufficient.

c8ef commented 2 months ago

I'm not sure why the patch is missing from the version released two weeks ago: https://github.com/libsdl-org/SDL/blob/release-2.30.6/src/sensor/android/SDL_androidsensor.c. It's quite strange.🙄

waruqi commented 2 months ago

we can use io.replace or add_patches to fix it.