xmake-io / xmake-vscode

🍩 A XMake integration in Visual Studio Code
https://xmake.io
Apache License 2.0
228 stars 55 forks source link

set_group bug in vscode #163

Closed Extra-Creativity closed 1 year ago

Extra-Creativity commented 1 year ago

Xmake Version

2.7.5

Operating System Version and Architecture

Win10 22H2, x86_64

Describe Bug

The minimal project that causes this bug has been uploaded to my temporary repository.

In this project, set_group here will cause incorrect subgroups in vscode.

Expected Behavior

VSCode will make Test2 a subgroup of Test.

Project Configuration

No response

Additional Information and Error Logs

No response

A2va commented 1 year ago

This is normal set_group work only with Visual Studio not Visual Studio Code

Extra-Creativity commented 1 year ago

Err..Okay, I mistake it as a feature for VSCode because of this discussion, where the maintainer thinks so.

So if not, could you please consider it as a to-do item? Currently, set_group will cause dump when generating Visual Studio project, as I mentioned in xmake issue, so it seems impossible to see whether it works on VS. But hopefully this feature can be extended to more IDEs or platforms :-).

waruqi commented 1 year ago

set_group will cause dump when generating Visual Studio project

@see https://github.com/xmake-io/xmake/issues/3303#issuecomment-1385494248

So if not, could you please consider it as a to-do item?

vscode support group, https://github.com/xmake-io/xmake-vscode/blob/8e0842ceb2056d270fb25e894590df4f735da46f/src/explorer.ts#L16

But it was contributed by others, maybe it's not stable. You can also debug the plugin source code yourself.

A2va commented 1 year ago

vscode support group

I didn't know that groups were supported by the extension. Anyway, for me, it seems to work properly (tested with your sample project): image

Extra-Creativity commented 1 year ago

I've updated the repository; now it should make Test2 a subgroup of Test, and the library Test3 and the executable file2.test should be in Test2; But it will only work like what you show, that is, those two are in the group Test rather than its subgroup.

A2va commented 1 year ago

I have fixed it ! image

waruqi commented 1 year ago

Thanks! I have updated plugin. please try it again.

Extra-Creativity commented 1 year ago

Appreciate your quick fix! Thank you!