xmake-io / xmake

🔥 A cross-platform build utility based on Lua
https://xmake.io
Apache License 2.0
10.14k stars 782 forks source link

bash命令行下的多目标补全失败 & 输入错误目标名不报错 #5259

Closed JackLin00 closed 4 months ago

JackLin00 commented 4 months ago

Xmake 版本

2.9.3

操作系统版本和架构

Ubuntu 20.04

描述问题

1.[bash命令行]当仓库上存在多个目标的时候,xmake build 无法根据首字母进行补全,当前只会提示所有目标 2.当输入 xmake build [一个不存在目标名],不会报错 上面两个问题在旧版本 2.6,7 上是不存在的

期待的结果

1.[bash命令行]能够正确地进行补全 2.输入不存在的目标名的时候,能够报错

工程配置

如附件 test_xmake_2.zip

附加信息和错误日志

Issues-translate-bot commented 4 months ago

Bot detected the issue body's language is not English, translate it automatically.


Title: Multi-target completion fails under the bash command line & no error is reported when entering an incorrect target name

Xmake version

2.9.3

Operating system version and architecture

Ubuntu 20.04

Describe the problem

1.[bash command line] When there are multiple targets on the warehouse, xmake build cannot complete based on the first letter. Currently, it will only prompt all targets.

  1. When entering xmake build [a target name that does not exist], no error will be reported The above two problems do not exist in old versions 2.6 and 7

Expected results

1.[bash command line] can complete correctly

  1. When entering a target name that does not exist, an error can be reported

Project configuration

As attached test_xmake_2.zip

Additional information and error logs

None

waruqi commented 4 months ago

暂时没空看这个,可以直接来个 pr 过来

Issues-translate-bot commented 4 months ago

Bot detected the issue body's language is not English, translate it automatically.


I don’t have time to read this at the moment, so I can send you a PR directly.

JackLin00 commented 4 months ago

补全问题我周末提一个 pr 过来,但是在查看输入错误目标名不报错的问题的时候,发现里面的逻辑链很深,不知道怎么解决,而且在查看的过程中发现里面有 xmake build -g [组名] 这个功能也是不行,建议重新梳理一下 build 的流程,我感觉里面会有不少的 bug

Issues-translate-bot commented 4 months ago

Bot detected the issue body's language is not English, translate it automatically.


I submitted a PR over the weekend to complete the problem, but when I checked the problem of not reporting an error when entering an incorrect target name, I found that the logic chain inside was very deep and I didn’t know how to solve it. During the review process, I found that there was xmake build -g in it. [Group name] This function is not working. I suggest you reorganize the build process. I feel there will be a lot of bugs in it.

JackLin00 commented 4 months ago

个人感觉一些基础的功能是大多数用户最常接触到,对项目的口碑影响相对于那些复杂的功能更大,就像8-2原则,如果存在多个这些问题,会很劝退新手,希望 xmake 越来越好

Issues-translate-bot commented 4 months ago

Bot detected the issue body's language is not English, translate it automatically.


Personally, I feel that some basic functions are most commonly encountered by most users and have a greater impact on the reputation of the project than those with complex functions. If there are multiple of these problems, it will be very discouraging for newbies. I hope xmake will get better and better.