search

xmartlabs / Bender

Easily craft fast Neural Networks on iOS! Use TensorFlow models. Metal under the hood.
https://xmartlabs.github.io/Bender/
MIT License
1.79k stars 90 forks source link

Tests fail in iOS 11.3.1 on iPhone 8+ #110

Closed mats-claassen closed 5 years ago

mats-claassen commented 6 years ago

In iOS 11.3.1 the tests for the Concat and LocalResponseNorm layers fail in iPhone 8 and iPhone X. They work in iOS 11.3 (to my understanding) and also if run on iPhone 7 or below.

I am not sure this is a Bender or an iOS issue.

PIRANAVARUBAN commented 6 years ago

Bug in iPhoneX in iOS 11.3

PIRANAVARUBAN commented 6 years ago

Any update about this Issue

mats-claassen commented 6 years ago

I haven't tested this on an iPhone 8 on Xcode 9.4. We reported the issue to Apple.

hollance commented 6 years ago

FWIW I noticed similar issues with my own compute kernels on the iOS 11.3 beta on A11 devices.

Edit: The issue was largely related to using ushort values in the compute kernels. With uint everything worked fine. According to Apple this should be fixed in iOS 12 but I haven't tried it yet.

mats-claassen commented 6 years ago

Thanks for the comment @hollance.

I haven't tried this on iOS 12 either but as you said this should be fixed in iOS 12. However, we were told that they might not fix it for iOS 11.x. It might be worth to see if changing ushort's to uint's fixes our issues.