search

xmartlabs / Eureka

Elegant iOS form builder in Swift
https://eurekacommunity.github.io
MIT License
11.79k stars 1.33k forks source link

IOS 14 Beta - Time Picker Changed. #2052

Closed johnlietzke closed 3 years ago

johnlietzke commented 4 years ago

IOS 14 Beta has changed the format of the Time Picker. No longer does a picker populate. It is an input dialog that comes up instead.

I am unable to change the color of the text row.

Screen Shot 2020-06-23 at 6 46 44 PM

Also, would it be possible to change the color of the dialog box?

Screen Shot 2020-06-23 at 6 46 54 PM
mats-claassen commented 4 years ago

I can confirm that it seems the DateRow type of rows don't work in iOS 14 beta. DateInlineRow or DatePickerRow works. Same for time and date+time pickers. Somehow the inputView is not shown

To continue using the wheels layout for the pickers you can use:

cell.datePicker.preferredDatePickerStyle = .wheels

I haven't taken a look yet into customizing the colors of the new compact picker.

johnlietzke commented 4 years ago

Thanks for the quick reply. I will try that.

I do not have date pickers in my app. I use a calendar setup for that.

But the new time input is kind of nice.

Thanks, John

On Jun 24, 2020, at 6:05 AM, Mathias Claassen notifications@github.com wrote:

 I can confirm that it seems the DateRow type of rows don't work in iOS 14 beta. DateInlineRow or DatePickerRow works. Same for time and date+time pickers. Somehow the inputView is not shown

To continue using the wheels layout for the pickers you can use:

cell.datePicker.preferredDatePickerStyle = .wheels I haven't taken a look yet into customizing the colors of the new compact picker.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

kamerc commented 4 years ago

@johnlietzke I know this doesn't help what you need since you were looking for TimeRow and not TimeInline row but I just submitted a pull request to fix the date & time inline rows so that they match the iOS native apps. The styles were not displaying correctly in iOS14.

johnlietzke commented 4 years ago

Thanks Kate, in the past the developers have waited until the GM version to make changes. I do like the new native date and time as it is smaller and easier to input. What do you think?

kamerc commented 4 years ago

@johnlietzke either way. With my changes there is still support for 13.4+ and less than 13.4 (the default still works, additional config not needed). It doesn't matter to me when it is merged in.

mats-claassen commented 3 years ago

Support for this has been released