search

xmartlabs / Eureka

Elegant iOS form builder in Swift
https://eurekacommunity.github.io
MIT License
11.79k stars 1.33k forks source link

URLRule requiresProtocol property isn't used #2071

Open criboldi opened 4 years ago

criboldi commented 4 years ago

When using the URLRule I assume that the requiresProtocol property would change make it so that the url 'www.google.com' would be valid while setting it to true would require the field to have http:// or https:// before the domain of the url.

Upon looking into the source code the property requiresProtocol defaults to false but is never used in calculating the isValid function.

I can make a quick fix and add a PR to this issue.

mats-claassen commented 4 years ago

You are right, it is never used. Yes please make a PR fixing that!