xmartlabs / Eureka

Elegant iOS form builder in Swift
https://eurekacommunity.github.io
MIT License
11.78k stars 1.33k forks source link

font colour change in PickerInlineRow #2116

Open Coners opened 3 years ago

Coners commented 3 years ago

PickerInlineRow font colour is no longer working as of todays apple iOS patch. where do I optionally set it?

what I mean is, it's gone from darkgrey on a slate background (we opted for the slate via $0.cellSetup({ (cell, row) in cell.backgroundcolor= self.slateBakground})) to faint text on slate and it is hard to read

Coners commented 3 years ago

Hi I just want to re-iterate there is no way whatsoever to change the PickerInlineRow selected value text colour. I spent 4 hours yesterday until 2am trying everything.

YOU CAN do:

but not

(which is by far the most seen, perhaps 99% of what you're looking at)

why is this? It has completely ruined my application look and feel. iOS altered the grey for the resting selected value font colour and it's almost invisible and the only way was to make all the pickers backgrounds different - which looks horrible and non uniform

Coners commented 3 years ago

Picker

As you can see the word "Manual" would be unreadable if the background was the same as "Tag" (which it used to be) the colour of the word "Manual" changes to black (as intended on tap) but the flaw is that the word "Manual" should be light grey on dark grey, I've had to inverse the colours to make it readable as of yesterdays iOS update forcing pale text everywhere

It looks hideous that inline spinners are now totally unlike the rest of the UI

mats-claassen commented 3 years ago

Does this not work for you?

.cellUpdate({ (cell, row) in
    cell.detailTextLabel?.textColor = .green
})
Coners commented 3 years ago

Thanks! I had tried cell.textLabel? only. I was looking inside the row for views as well.

I did not see that despite looking about 12 times through the entire list, if I may say, now it's been brought to my attention surely it's the other way round?

DetailText is surely the label, describing the item, whereas text is the text value?

mats-claassen commented 3 years ago

detailTextLabel and textLabel are variables of UITableViewCell. There are different possible layouts so textLabel won't always be on the left and detailTextLabel on the right. You can check that out in the Apple documentation

Coners commented 3 years ago

detailTextLabel and textLabel are variables of UITableViewCell. There are different possible layouts so textLabel won't always be on the left and detailTextLabel on the right. You can check that out in the Apple documentation

Silly move from Apple. Who wouldn't extend past that ?

They live in a world of their own those guys. Honestly