search

xmartlabs / PagerTabStripView

🚀 Elegant Pager View fully written in pure SwiftUI.
MIT License
774 stars 88 forks source link

Unable to build the project with Xcode 15.2 #138

Open sushil-tiwari opened 10 months ago

sushil-tiwari commented 10 months ago

Describe the bug I am working on an ongoing project where I am using PagerTabStripView library. I have added it as SPM. The project is compiling and building successfully with Xcode 14.2.

I have upgraded my Xcode to 15.2 and the same project is not compiling. When compiling the project with Xcode 15.2, I am seeing below error. Reference screenshots are attached.

Error: Initializer for conditional binding must have Optional type, not 'CGFloat'

To Reproduce Steps to reproduce the behavior:

  1. Use library version 3.2.0 in the project
  2. Compile it with Xcode 15.2
  3. Check the build error

Expected behavior The project should be commpiled with Xcode 15.

Screenshots

Screenshot 2024-01-10 at 4 53 12 PM Screenshot 2024-01-10 at 4 47 55 PM Screenshot 2024-01-10 at 4 48 17 PM

Versions (please complete the following information):

pyby commented 9 months ago

I saw a branch named v3.2.1. The only commit fixed the build.

https://github.com/xmartlabs/PagerTabStripView/commit/3fcfe519e92242fe6c132025045f75994c0a13e8

Would it be possible to manually tag this commit to 3.2.1 @cecipirotto ?

For now, we can use the SPM dependency "commit" with this commit hash.

sushil-tiwari commented 9 months ago

I saw a branch named v3.2.1. The only commit fixed the build.

3fcfe51

Would it be possible to manually tag this commit to 3.2.1 @cecipirotto ?

For now, we can use the SPM dependency "commit" with this commit hash.

@pyby Thank you for the followup and update. I switched to version 4.0.0 and it is working fine. For this, I had to change the minimum OS support to iOS 16.