Refactor code, solve several issues

xmartlabs / PagerTabStripView

🚀 Elegant Pager View fully written in pure SwiftUI.

MIT License

774 stars 88 forks source link

Refactor code, solve several issues #97

Closed mtnbarreto closed 1 year ago

mtnbarreto commented 1 year ago

Fixes #issue(s) .

Changes proposed in this request:

Selection value now can be any hashable type
Layout protocol use to arrange subviews in scrollable and non-scrollable navbar items. No longer need to use geometry reader to get the tab size to position the indicator. Simplifies a lot the base code.

mtnbarreto commented 1 year ago

Github action is no loger working... Could you update the tools versions @mats-claassen ?

mtnbarreto commented 1 year ago

Readme should be updated. @cecipirotto go ahead if you are willing to do so.

coffmark commented 1 year ago

I pulled this branch, but there may already be an error. I think ProposedViewSize is iOS16 or higher. So, I think you need available attributes. (like @available(iOS 16.0, *))

I'm looking forward to this changes! Thank you!

mtnbarreto commented 1 year ago

Hi @coffmark!

These changes require iOS 16 Layout protocol was just released by apple. I mean it will not longer support ios 15, neither ios 14.

Developers that need iOS 14, and iOS 15 support can continue using older versions, at least until iOS 16 adoption increases.

mtnbarreto commented 1 year ago

We already merged these changes, so i'm closing this pr.